Skip to content

fix(lightning): tune scorer params - #1102

Merged
pwltr merged 1 commit into
masterfrom
fix/scorer-next
Jul 24, 2026
Merged

fix(lightning): tune scorer params#1102
pwltr merged 1 commit into
masterfrom
fix/scorer-next

Conversation

@pwltr

@pwltr pwltr commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Description

Improves Lightning route selection by tuning node-wide scorer fee params. These params have been used in nightly probing testing as the next variant. See comparison to current (stable) here.

iOS counterpart: synonymdev/bitkit-ios#639

@pwltr
pwltr marked this pull request as ready for review July 24, 2026 10:34
@pwltr
pwltr requested a review from piotr-iohk July 24, 2026 10:34
@greptile-apps

greptile-apps Bot commented Jul 24, 2026

Copy link
Copy Markdown

Greptile Summary

The PR tunes Lightning route scoring parameters:

  • Reduces the node-wide base penalty from 50,000 msat to 40,000 msat.
  • Removes the 60,000 msat probing-diversity override, causing the existing default value of zero to be retained.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The changes consistently apply the intended scorer tuning through the existing node-builder configuration, and no broken contract or reachable failure is established.

Important Files Changed

Filename Overview
app/src/main/java/to/bitkit/services/LightningService.kt Updates two scorer fee parameters used when configuring the Lightning node; no concrete correctness issue was identified.

Reviews (1): Last reviewed commit: "fix(lightning): tune scorer params" | Re-trigger Greptile

@piotr-iohk piotr-iohk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, given probing nightly results.

@pwltr
pwltr merged commit 40c36f6 into master Jul 24, 2026
27 checks passed
@pwltr
pwltr deleted the fix/scorer-next branch July 24, 2026 15:21
@ovitrif ovitrif added this to the 2.5.0 milestone Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants