Skip to content

fix(lightning): tune scorer params - #639

Merged
pwltr merged 1 commit into
masterfrom
fix/scorer-next
Jul 24, 2026
Merged

fix(lightning): tune scorer params#639
pwltr merged 1 commit into
masterfrom
fix/scorer-next

Conversation

@pwltr

@pwltr pwltr commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Description

Improves Lightning route selection by tuning node-wide scorer fee params. These params have been used in nightly probing testing as the next variant. See comparison to current (stable) here.

Android counterpart: synonymdev/bitkit-android#1102

@pwltr
pwltr requested a review from piotr-iohk July 24, 2026 10:34
@pwltr
pwltr marked this pull request as ready for review July 24, 2026 10:34
@greptile-apps

greptile-apps Bot commented Jul 24, 2026

Copy link
Copy Markdown

Greptile Summary

Updates Lightning route-scoring parameters:

  • Lowers the node-wide base penalty from 50,000 to 40,000 msat.
  • Uses the configured/default probing-diversity penalty instead of overriding it with 60,000 msat.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete correctness or security failures identified in the scorer parameter tuning.

The setup path continues to construct and apply the complete scoring parameter set, while the changed values align with the PR’s stated route-selection tuning.

Important Files Changed

Filename Overview
Bitkit/Services/LightningService.swift Adjusts two scorer fee parameters used when configuring LDK Node route selection; no actionable defect was identified.

Reviews (1): Last reviewed commit: "fix(lightning): tune scorer params" | Re-trigger Greptile

@pwltr
pwltr merged commit eedf94e into master Jul 24, 2026
22 checks passed
@pwltr
pwltr deleted the fix/scorer-next branch July 24, 2026 15:21
@ovitrif ovitrif added this to the 2.5.0 milestone Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants