Skip to content

fix(ci): hydrate LFS dependencies in builds - #6055

Merged
renecannao merged 1 commit into
GH-Actionsfrom
fix/ci-builds-lfs-checkout
Aug 13, 2026
Merged

fix(ci): hydrate LFS dependencies in builds#6055
renecannao merged 1 commit into
GH-Actionsfrom
fix/ci-builds-lfs-checkout

Conversation

@renecannao

@renecannao renecannao commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

What changed

Enable Git LFS hydration in the reusable CI-builds checkout.

Root cause

The AWS SDK source archive is intentionally stored in Git LFS. CI-builds checked out pull-request commits with lfs: false, leaving the pointer file in place. The vendored bundle checksum then failed before ProxySQL or its tests could build.

Validation

  • Reproduced the current checkout contract failure before the change.
  • Parsed the updated reusable workflow and verified the checkout step has lfs: true.
  • git diff --check passes.

This PR targets GH-Actions; it is required before rerunning the standard CI-builds jobs for PR #6048.


Summary by cubic

Hydrates Git LFS files during CI builds so the AWS SDK archive is present. Previously actions/checkout used lfs: false and left pointer files, causing vendored bundle checksum failures; now it sets lfs: true so builds and tests proceed.

Written for commit fc4ba9d. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Chores
    • Updated the build workflow to retrieve Git LFS-managed files during checkout.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ab42a181-ef40-4bb1-b39e-0860c86be700

📥 Commits

Reviewing files that changed from the base of the PR and between 8c38cf3 and fc4ba9d.

📒 Files selected for processing (1)
  • .github/workflows/ci-builds.yml
📜 Recent review details
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-07-08T13:19:04.649Z
Learnt from: CR
Repo: sysown/proxysql PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-07-08T13:19:04.649Z
Learning: The proxysql binary under test must be a DEBUG build when running the isolated TAP harness.

Applied to files:

  • .github/workflows/ci-builds.yml
🔇 Additional comments (1)
.github/workflows/ci-builds.yml (1)

213-213: LGTM!


📝 Walkthrough

Walkthrough

The CI workflow now enables Git LFS in the repository checkout step while preserving the existing checkout settings.

Changes

CI Git LFS checkout

Layer / File(s) Summary
Enable Git LFS checkout
.github/workflows/ci-builds.yml
The actions/checkout step adds lfs: true and retains the existing repository, ref, fetch-depth, and path settings.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Mergeability Score: ⚪ Minimal · up to fc4ba

This localized CI change enables required LFS-backed dependencies during builds, addressing the reported checkout failure. No actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

  • sysown/proxysql#6019: Both changes modify the actions/checkout step in .github/workflows/ci-builds.yml.

Poem

I’m a rabbit in CI, quick and light,
Git LFS now brings the files just right.
The checkout keeps its path and ref,
With shallow fetch settings left intact.
Hop, hop—builds begin! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes enabling Git LFS hydration in CI builds, which is the primary change.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ci-builds-lfs-checkout

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gitar-bot

gitar-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Enables Git LFS hydration in the reusable CI-builds workflow checkout step to prevent AWS SDK bundle checksum failures. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@renecannao
renecannao marked this pull request as ready for review August 13, 2026 12:56

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@sonarqubecloud

Copy link
Copy Markdown

@renecannao
renecannao merged commit 67def10 into GH-Actions Aug 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant