fix(typescript): switch to linking to prebuilt packages#789
Merged
chris-olszewski merged 1 commit intomainfrom Mar 26, 2026
Merged
fix(typescript): switch to linking to prebuilt packages#789chris-olszewski merged 1 commit intomainfrom
chris-olszewski merged 1 commit intomainfrom
Conversation
THardy98
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Switch from
filetolinkprotocol since we don't need to "install" the locally built packages, but can instead just symlink to them.Why?
Previously we would fail if attempting to use a local checkout for running tests e.g. as the local setup would use
workspace:protocol which cannot be resolved outside of that workspace so installation would fail.Checklist
Closes
How was this tested:
go run . run --lang ts --version "$(realpath ../typescript)"andgo run . run --lang tsnow both pass locally for me. Previously specifying version as a path would result in the failure described above.Any docs updates needed?