Skip to content

Remove entrypoints#86

Open
NoNameWasDefined wants to merge 1 commit into
termux:masterfrom
NoNameWasDefined:remove-entrypoint
Open

Remove entrypoints#86
NoNameWasDefined wants to merge 1 commit into
termux:masterfrom
NoNameWasDefined:remove-entrypoint

Conversation

@NoNameWasDefined

Copy link
Copy Markdown

Entrypoints are not needed anymore after #85

This pull request:

  • remove all entrypoint files (entrypoint.sh, entrypoint_root.sh) and all references to them

  • suggest in README.md to directly change the UID instead of using /entrypoint_root.sh to login as root

This will break projects that explicitly use entrypoints, for example some had to specify the entrypoint in GitHub Actions workflows.

@robertkirkman

robertkirkman commented Jun 17, 2026

Copy link
Copy Markdown
Member

This will break projects that explicitly use entrypoints, for example some had to specify the entrypoint in GitHub Actions workflows.

One of the reasons that I have not removed the /entrypoint.sh is because it is used in production code by company https://astral.sh/ at this line:

https://github.com/astral-sh/uv/blob/576f28e0568e17b59882fac62d0ccafa80ff10f0/.github/workflows/test-integration.yml#L793

and representatives of astral.sh have not yet responded to the initiation of new discussion about this topic here:

Comment thread Dockerfile
@NoNameWasDefined

Copy link
Copy Markdown
Author

I understand the implications.

I have a solution for /entrypoint.sh that would just creating a dummy /entrypoint.sh like before, but for /entrypoint_root.sh I don't see any solution.

@robertkirkman

Copy link
Copy Markdown
Member

I understand the implications.

I have a solution for /entrypoint.sh that would just creating a dummy /entrypoint.sh like before, but for /entrypoint_root.sh I don't see any solution.

Please attempt to port the GitHub Actions container: directive to this PR version of termux-docker (this might or might not be easy/possible, if possible then good)

here is the port of the GitHub Actions container: directive to the current master branch of termux-docker:

https://github.com/robertkirkman/termux-on-gha/blob/4ba8290d008ad2f1f95369761f96ad0fd34900d2/.github/workflows/build-and-test.yml

Comment thread Dockerfile
- remove all entrypoint files (entrypoint.sh, entrypoint_root.sh) and
  all references to them

- suggest in README.md to directly change the UID instead of using
  /entrypoint_root.sh to login as root
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants