Skip to content

Remove entrypoints #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NoNameWasDefined wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −49
Open

Remove entrypoints #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,5 +73,5 @@ COPY --from=bootstrap / /
WORKDIR ${TERMUX__HOME}
SHELL ["sh", "-c"]

ENTRYPOINT ["/entrypoint.sh"]
Comment thread
NoNameWasDefined marked this conversation as resolved.
USER 1000:1000
Comment thread
NoNameWasDefined marked this conversation as resolved.
CMD ["login"]
10 changes: 2 additions & 8 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,18 +107,12 @@ docker run -it --rm termux/termux-docker bash -c "apt update && apt install -yq

By default root shell is disabled in container as Termux doesn't really
support usage of package manager under root account. In cases where you
really need shell with root privileges, entrypoint should be overridden.

The provided images have 2 entry points:

- `/entrypoint.sh` - the standard one which drops privileges to `system`
user.
- `/entrypoint_root.sh` - alternate entrypoint that does not drop privileges.
really need shell with root privileges, the user should be overridden.

Usage example:

```.sh
docker run -it --entrypoint /entrypoint_root.sh termux/termux-docker
docker run -it --user 0 termux/termux-docker
```

## Building image
Expand Down
22 changes: 0 additions & 22 deletions entrypoint.sh
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions entrypoint_root.sh
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions generate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,12 +410,6 @@ root:x:0:0:root:/:/system/bin/sh
system:x:1000:1000:system:${TERMUX__ROOTFS}/home:${TERMUX__PREFIX}/bin/login
EOF

echo "[*] Copying entrypoint.sh to /..."
cp entrypoint.sh "${TERMUX_DOCKER__ROOTFS}/"

echo "[*] Copying entrypoint_root.sh to /..."
cp entrypoint_root.sh "${TERMUX_DOCKER__ROOTFS}/"

echo "[*] Setting permissions..."
find -L "${TERMUX_DOCKER__ROOTFS}/data" \
-type d -exec \
Expand Down
Loading