Skip to content

Display correct error message for invalid users#5

Merged
Time-Green merged 1 commit into
tgstation:mainfrom
SyncIt21:Fix4
Jun 9, 2026
Merged

Display correct error message for invalid users#5
Time-Green merged 1 commit into
tgstation:mainfrom
SyncIt21:Fix4

Conversation

@SyncIt21

@SyncIt21 SyncIt21 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor
  • Don't throw error just display the message for 404 directly

@SyncIt21

SyncIt21 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Hi @Time-Green. Apparently I can ask any maintainer in tg cause they also have write access on other repos.

Could you please merge this? I already bothered Melbert and Lemon enough for my other PRs

@Time-Green

Copy link
Copy Markdown
Member

I don’t know JS and don’t feel confortable merging it without understanding it. It’s also only been 25 minutes

You can ping me again in a few days if no one got to it and I will make an attempt

@SyncIt21

SyncIt21 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

@Time-Green It's fine. I understand your concerns in reviewing but I'm the one who created this repo

Lemon & Melbert merged my PRs without reviewing because they trusted me. That's what I'm asking for your trust

You trust me right 🥲?

@Time-Green Time-Green merged commit 19c8172 into tgstation:main Jun 9, 2026
1 check passed
@Time-Green

Copy link
Copy Markdown
Member

It’s probably fine?…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants