Display correct error message for invalid users#5
Merged
Conversation
SyncIt21
commented
Jun 9, 2026
Contributor
- Don't throw error just display the message for 404 directly
Contributor
Author
|
Hi @Time-Green. Apparently I can ask any maintainer in tg cause they also have write access on other repos. Could you please merge this? I already bothered Melbert and Lemon enough for my other PRs |
Member
|
I don’t know JS and don’t feel confortable merging it without understanding it. It’s also only been 25 minutes You can ping me again in a few days if no one got to it and I will make an attempt |
Contributor
Author
|
@Time-Green It's fine. I understand your concerns in reviewing but I'm the one who created this repo Lemon & Melbert merged my PRs without reviewing because they trusted me. That's what I'm asking for your trust You trust me right 🥲? |
Member
|
It’s probably fine?… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.