Skip to content

Display correct error message for invalid users #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Time-Green merged 1 commit into from
Jun 9, 2026
Merged

Display correct error message for invalid users #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33228,17 +33228,14 @@ async function run() {
//Remove Invalid users
for (const user of trimmed_owners.toReversed()) {
try {
const response = await octokit.rest.issues.checkUserCanBeAssigned({
await octokit.rest.issues.checkUserCanBeAssigned({
owner: core_owner,
repo: core_repo,
assignee: user
});
if (response.status != 204) {
throw new Error(`Cannot be requested for review, make sure they are a member of a team with read access.`);
}
}
catch (ex) {
notice(`Error verifying user ${user}: ${ex}`);
catch {
notice(`User ${user}: Cannot be requested for review, make sure they are a member of a team with read access.`);
trimmed_owners.splice(trimmed_owners.indexOf(user), 1);
}
}
Expand Down
22 changes: 9 additions & 13 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,19 +170,15 @@ async function run(): Promise<void> {
//Remove Invalid users
for (const user of trimmed_owners.toReversed()) {
try {
const response: RestEndpointMethodTypes['issues']['checkUserCanBeAssigned']['response'] =
await octokit.rest.issues.checkUserCanBeAssigned({
owner: core_owner,
repo: core_repo,
assignee: user
})
if (response.status != 204) {
throw new Error(
`Cannot be requested for review, make sure they are a member of a team with read access.`
)
}
} catch (ex) {
notice(`Error verifying user ${user}: ${ex}`)
await octokit.rest.issues.checkUserCanBeAssigned({
owner: core_owner,
repo: core_repo,
assignee: user
})
} catch {
notice(
`User ${user}: Cannot be requested for review, make sure they are a member of a team with read access.`
)
trimmed_owners.splice(trimmed_owners.indexOf(user), 1)
}
}
Expand Down