fix(src/logic-engine): prevent global prototype pollution in agent sandbox#496
Closed
MatrixNeoKozak wants to merge 1 commit into
Closed
fix(src/logic-engine): prevent global prototype pollution in agent sandbox#496MatrixNeoKozak wants to merge 1 commit into
MatrixNeoKozak wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for catching this. I’m going to take this over and push an adjusted version, mainly because the current patch changes how logic scripts are evaluated. Existing Zeroshot trigger scripts are written as function bodies and rely on I’ll keep the intent of your change, add regression coverage, and make sure you’re credited for spotting the issue. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic engine sandbox was incorrectly attempting to prevent prototype pollution by manually freezing global constructor prototypes from the outer scope, which actually caused the reverse effect and introduced a vulnerability by modifying global behavior. This change removes the unsafe manual prototype freezing and reliance on outer-scope constructors, instead relying on
vm.createContextto provide a genuinely isolated environment with its own standard globals. This also simplifies the sandbox execution logic and improves security.