fix(logic-engine): isolate trigger sandbox globals#521
Merged
Conversation
Preserve the existing return-based trigger script contract while avoiding host Object/Array prototype freezing during VM evaluation. Refs: #496 Reported-by: KozakLordOfMatrix <matrixneo2026@tutamail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
return-based trigger logic contract while running scripts against VM-owned globals.LogicEngine.evaluate().Object.prototype/Array.prototype.Unreleasedchangelog note for release notes, referencing fix(src/logic-engine): prevent global prototype pollution in agent sandbox #496.Validation
npm cinpx mocha tests/integration/trigger-evaluation.test.js --timeout 10000objectPrototypeFrozen/arrayPrototypeFrozenwere true)npm run test:slow-> 131 passing, 17 pendingnpm run validate:templates-> all templates valid; existing warnings onlynpm run check-> 0 errors, 115 existing warningsnpx prettier --check CHANGELOG.md src/logic-engine.js tests/integration/trigger-evaluation.test.jsNo release performed.