refactor: update InfiniteScrollingDataSource and preview#454
Merged
piercifani merged 3 commits intodevelopfrom Feb 20, 2026
Merged
refactor: update InfiniteScrollingDataSource and preview#454piercifani merged 3 commits intodevelopfrom
piercifani merged 3 commits intodevelopfrom
Conversation
Remove Combine and replace @published with SwiftUI's @observable annotations for better performance with SwiftUI 18. Utilize the @ObservationIgnored attribute for non-observable properties. Simplify preview code by removing unnecessary @StateObject and @ObservedObject wrappers, as the @observable protocol already manages state changes efficiently.
Introduce an Android-compatible static creation method in InfiniteScrollingDataSource for improved support across platforms. This change ensures that the class can be instantiated on Android OS, broadening the potential use cases and facilitating platform- specific adaptations. Adjust the initializer to cater to these specifications while preserving existing functionality.
This reverts commit bb5f8ee.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Combine and replace @published with SwiftUI's @observable annotations for better performance with SwiftUI 18. Utilize the @ObservationIgnored attribute for non-observable properties. Simplify preview code by removing unnecessary @StateObject and @ObservedObject wrappers, as the @observable protocol already manages state changes efficiently.