Skip to content

refactor: update InfiniteScrollingDataSource and preview #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
piercifani merged 3 commits into from
Feb 20, 2026
Merged

refactor: update InfiniteScrollingDataSource and preview #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b865abf
refactor: update InfiniteScrollingDataSource and preview
MarcHidalgo5 Feb 20, 2026
bb5f8ee
feat: add Android compatibility to InfiniteScrollingDataSource
MarcHidalgo5 Feb 20, 2026
0ae37f5
Revert "feat: add Android compatibility to InfiniteScrollingDataSource"
MarcHidalgo5 Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions Sources/BSWInterfaceKit/SwiftUI/DataSource/InfiniteScrollingDataSource.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
#if canImport(Darwin)

import SwiftUI
import Combine
import Observation

/// As of iOS 18 and aligned releases, this is no longer recommended as
/// there are cleaner alternatives like `InfiniteVerticalScrollView`
@MainActor
open class InfiniteScrollingDataSource<ListItem: Identifiable & Sendable>: ObservableObject {
@Observable
open class InfiniteScrollingDataSource<ListItem: Identifiable & Sendable> {

@Published public private(set) var items = [ListItem]()
@Published public private(set) var state: State
@Published public var paginationError: Error?
public private(set) var items = [ListItem]()
public private(set) var state: State
public var paginationError: Error?
@ObservationIgnored
private var itemFetcher: ItemFetcher

public enum State: Equatable {
Expand Down Expand Up @@ -106,5 +107,3 @@ open class InfiniteScrollingDataSource<ListItem: Identifiable & Sendable>: Obser
}
}
}

#endif
4 changes: 2 additions & 2 deletions Sources/BSWInterfaceKit/SwiftUI/Previews/InfiniteScrollingDataSource+Preview.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ struct InfiniteDataSource_Previews: PreviewProvider {

struct ItemListView: View {

@StateObject var dataSource: ItemInfiniteDataSource
var dataSource: ItemInfiniteDataSource

var body: some View {
List {
Expand All @@ -67,7 +67,7 @@ struct InfiniteDataSource_Previews: PreviewProvider {

struct FooterView: View {

@ObservedObject var dataSource: ItemInfiniteDataSource
var dataSource: ItemInfiniteDataSource

var body: some View {
HStack(spacing: 8) {
Expand Down