[SKIP SOF-TEST] ci: fix stub build overlay passing#8259
[SKIP SOF-TEST] ci: fix stub build overlay passing#8259cujomalainey wants to merge 2 commits intothesofproject:mainfrom
Conversation
cujomalainey
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
|
still broken, its like CI is no longer consuming the config |
cujomalainey
force-pushed
the
stub-fix
branch
from
d67c709 to
dadf0c6
Compare
cujomalainey
changed the title
cujomalainey
force-pushed
the
stub-fix
branch
4 times, most recently
from
f85483c to
e28a854
Compare
remove errnous -D Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
remove quotes so params are unquoted and actually parsed by cmake Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
cujomalainey
force-pushed
the
stub-fix
branch
from
e28a854 to
b3b02a0
Compare
|
Bash truly is a cursed hammer This is now ready for review |
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
I was on vacation for #7967 so I didn't catch commit deed9a8... you should totally not parse overlay files in bash!!
You can just pass an overlay file to west directly, all at once. See example in https://github.com/thesofproject/sof/actions/runs/6223015337/job/16888066452
west build --build-dir build-tgl --board intel_adsp_cavs25 \
/zep_workspace/sof/app -- -DEXTRA_CFLAGS=-Werror -DOVERLAY_CONFIG=/zep_workspace/sof/app/overlays/tgl/ipc4_overlay.conf
Bash truly is a cursed hammer
Sure but this one was self-inflicted I'm afraid :-)
marc-hb
changed the title
|
Ping @cujomalainey |
Busy internally with planning, feel free to take it over, otherwise it will wait |
|
@marc-hb are you able to complete this one ? I think its going to be useful for all the work that's being done converting modules to module API. |
|
OK, will do this week. |
|
#8411 merged. |
4 participants
As a result we missed a bad path configoverlays were not being passed correctly to west