dai-zephyr: refactor dai params#8415
Conversation
RanderWang
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
RanderWang
force-pushed
the
dai_refactor
branch
from
c7a240e to
043477c
Compare
btian1
left a comment
btian1
left a comment
There was a problem hiding this comment.
the code already mismatched, if possible, I would suggest to split with several patches for better check and bisect.
RanderWang
force-pushed
the
dai_refactor
branch
from
043477c to
ca91a24
Compare
NO, it is based on latest code |
|
All tests pass! the original PR got 3 approve. Thanks! |
mismatch means code are mismatched, hard to review and revert, after this patch merged, and then following dai code changed continue, once you want to revert this patch due to a regression bug based on latest sof code, it will be hard, have to use reset. if possible, split will make easy to read/review/maintain. |
Refactor dai params into more feasible functions and remove duplicate code. No functional change. Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com> Signed-off-by: Rander Wang <rander.wang@intel.com>
RanderWang
force-pushed
the
dai_refactor
branch
from
ca91a24 to
ed8e2b2
Compare
|
fixed the double free, thanks! |
|
The smart-amp stub build fail is unrelated, proceeding with merge. |
4 participants
Refactor dai params into more feasible functions and remove duplicate code. No functional change.
The original pr: #7345 was done by Jaska but was not merged. Since he has leaved intel, I will help to rebase it and submit it again .