Develop#23
Merged
Merged
Conversation
- TelemetryOptions.Enabled now defaults to true (set false to disable) - AddTelemetry(IConfiguration) overloads accept an optional sectionName to bind a section other than the default "Telemetry" - Update README (table, examples, quick start, custom-section docs) and AGENTS.md Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Added: - AdditionalTracingSources / AdditionalMeters config options (AddSource/AddMeter from appsettings.json, no code required) - Optional sectionName parameter on AddTelemetry(IConfiguration) overloads Changed: - Enabled now defaults to true - netstandard2.0 build no longer references OpenTelemetry.Instrumentation.AspNetCore (web-only target); WPF/console consumers stay lean - Updated Sample project NuGet packages to latest Removed: - EnableSqlClientInstrumentation and the built-in SqlClient instrumentation dependency; database instrumentation is now added via ConfigureTracing or AdditionalTracingSources (BREAKING) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Relocated the auto-release skill from the repo (.claude/skills/auto-release) to the user-global ~/.claude/skills. The update check now inspects only the shipped library project instead of the whole solution, so Sample/Tests package bumps no longer trigger a release. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Brings the skill back into the repository (it is entirely repo-specific) and renames it auto-release -> prepare-release, since it only prepares the release (version bump, notes, PR) — publishing stays a manual Deploy Nuget trigger. Documents the skill in AGENTS.md and CONTRIBUTING.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Cut from 21 to 11 tags: deduplicate Traces/Tracing and Logs/Logging, drop platform stuffing (WinForms/UWP/MAUI/Console) and niche tags (HttpClient/gRPC/ Instrumentation), and add Observability. Removed the now-stale SqlClient tag — that instrumentation was dropped in v2.0.0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Rename the existing sample to OpenTelemetryExtension.Configuration.Sample.WebApi and add a new OpenTelemetryExtension.Configuration.Sample.Wpf (net10.0-windows) that wires AddTelemetry() through the Generic Host and emits a custom ActivitySource/Meter plus an HttpClient span on a button click. Also: - README: add a Samples overview, update sample paths, fix the stale "SQL Client built-in" feature line (SQL instrumentation became opt-in in v2.0.0). - slnx: register both sample projects and fix the dangling auto-release skill folder paths left over from the prepare-release rename. - smoke-test.sh / AGENTS.md: point at the renamed Sample.WebApi project. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
… SQL Server
New OpenTelemetryExtension.Configuration.IntegrationTests project emits telemetry
through AddTelemetry() to a live OpenObserve instance (the Helm chart) and queries
its _search API to assert the data arrived:
- logs and traces in the "default" stream filtered by service_name
- a custom counter metric in its own metrics stream
- a SQL Server command span (Microsoft.Data.SqlClient + AddSqlClientInstrumentation),
asserting db_system_name = "microsoft.sql_server"
Tests are marked [Trait("Category","Integration")] via a custom IntegrationFact /
SqlIntegrationFact that auto-skips when OpenObserve / SQL Server is unreachable, so
a normal dotnet test run never fails without the stack. Endpoints/credentials
default to the Helm chart values and are overridable via OTEL_IT_* env vars.
Docs & CI:
- CONTRIBUTING.md / AGENTS.md: document the integration tests and the rule to run
unit tests (always) plus integration tests (when the stack is up) on feature work.
- ci.yml: filter Category!=Integration on the unit test run.
- deploy-nuget.yml: build only the library + unit tests (the solution now contains a
net10.0-windows WPF sample that cannot build on the Linux deploy runner).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Tag both unit test classes with [Trait("Category", "Unit")] and switch the test
execution filters from Category!=Integration to the positive Category=Unit in the
CI and deploy workflows and the prepare-release skill, so only unit tests run
there.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Move the test plumbing (IntegrationConfig, Reachability, OpenObserveClient, OtelTestHost, IntegrationFact attributes) into an Infrastructure/ subfolder and namespace, leaving only the actual test classes at the project root. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Avoids clashing with the repo's infrastructure/ directory (real Helm/Docker infra). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.