feat: add net8.0 target framework#27
Merged
Merged
Conversation
netstandard2.0 consumers on .NET 8 fell back to the netstandard2.0 asset, which excludes ASP.NET Core instrumentation. A dedicated net8.0 target gives .NET 8 (LTS) consumers the full feature set, on par with net10.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
net8.0to the library's target frameworks (netstandard2.0;net8.0;net10.0).Why
The package already ran on .NET 8 via the
netstandard2.0asset — but that asset excludes the ASP.NET Core instrumentation (OpenTelemetry.Instrumentation.AspNetCoreis conditioned on!= netstandard2.0, and the#if !NETSTANDARD2_0code paths are compiled out). So .NET 8 web apps got tracing/metrics/logging + HttpClient + Runtime, but no ASP.NET Core instrumentation and noExcludedPathsrequest filter.A dedicated
net8.0target (LTS) closes that gap: .NET 8 consumers now resolve thenet8.0asset and get full feature parity withnet10.0. .NET 9 apps fall back to thenet8.0asset cleanly.Changes
TargetFrameworksnownetstandard2.0;net8.0;net10.0. The existing!= netstandard2.0condition automatically pulls in AspNetCore instrumentation fornet8.0; the#if !NETSTANDARD2_0guards already cover it.Verification
dotnet buildsucceeds for all three TFMs (netstandard2.0,net8.0,net10.0), 0 warnings.Note
No
<Version>bump or release note here — per GitHub Flow the version is cut separately by theprepare-releaseskill. This is a new feature for consumers (MINOR), so the next release should be 2.1.0.