Fix branch_data_mode 'none' error message to point at omission#174
Draft
sandshoes wants to merge 1 commit into
Draft
Fix branch_data_mode 'none' error message to point at omission#174sandshoes wants to merge 1 commit into
sandshoes wants to merge 1 commit into
Conversation
The test expecting this hint was added in bdc22b8 but the code still fell through to the generic invalid-value error. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing test
throws when branch_data_mode is none, pointing at omission.Commit bdc22b8 updated the test to expect a dedicated hint when a config sets
branch_data_mode: "none", butresolveBranchDataModewas never given that special case —'none'fell through to the generic "Invalid branch_data_mode" error. This adds an explicit check so users are told to omit the field instead:Full suite passes (1062 tests).
🤖 Generated with Claude Code