Skip to content

Fix branch_data_mode 'none' error message to point at omission #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sandshoes wants to merge 1 commit into
base: protm-1348
Choose a base branch
from
Draft

Fix branch_data_mode 'none' error message to point at omission #174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/cli/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,11 @@ function resolveBranchDataMode(raw: Record<string, unknown>): { mode: BranchData
if (typeof value !== "string") throw new Error("branch_data_mode must be a string.");
const mode = value.trim().toLowerCase();
if (!mode) return { mode: null, explicit: false };
if (mode === "none") {
throw new Error(
"Invalid branch_data_mode 'none'. Omit branch_data_mode to create branches without data (the default)."
);
}
if (!BRANCH_DATA_MODE_VALUES.includes(mode as BranchDataMode)) {
throw new Error(
`Invalid branch_data_mode '${value}'. Allowed values are: ${BRANCH_DATA_MODE_VALUES.join(", ")}.`
Expand Down