Trace BindingSpace trie traversal - #84
Closed
MesTTo wants to merge 19 commits into
Closed
Conversation
Contributor
Author
|
Closing with the rest of the binding_space line: these counters instrument the sidecar's reimplemented join, which is parked, so the numbers they report are not the engine's. The concept is wanted (traversal statistics under a flag, e.g. every-Nth-point and average path length) and should be rebuilt as a small standalone PR instrumenting the real PathMap/ProductZipper traversal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack dependency: review after #83. This branch is based on the prerequisite head. Until the prerequisite PRs merge, GitHub may include their commits in the aggregate diff; the intended review increment is the new commit at this branch tip.
Traces BindingSpace trie traversal.
The branch adds a non-materializing trace for the trie-backed variable-at-a-time join.
trie_join_tracerecords the variable order, indexed row and trie-node counts, candidate binding count, and each variable-depth domain intersection.BindingSidecarPlan::explain_selected_trie_traceexposes the trace through the selected-kernel explain path. The trace is present only when the selector chooses the suggested-order trie join.Validation:
cargo +nightly-2026-06-01 test -p mork --lib binding_planwithRUSTFLAGS='-C target-cpu=native'cargo +nightly-2026-06-01 test -p mork --lib binding_spacewithRUSTFLAGS='-C target-cpu=native'cargo +nightly-2026-06-01 test -p mork --libwithRUSTFLAGS='-C target-cpu=native'rustfmt --checkonkernel/src/binding_plan.rsandkernel/src/binding_space.rsjscpdonkernel/src/binding_plan.rs,kernel/src/binding_space.rs,kernel/src/expression_trie.rs,kernel/src/pattern_relations.rs,kernel/src/test_exprs.rs, andkernel/src/test_sidecar_queries.rsgit diff --checkgit diff -w --stat