Pull to-device event list out of returned tuple#332
Open
AndrewFerr wants to merge 7 commits intoturt2live:mainfrom
Open
Pull to-device event list out of returned tuple#332AndrewFerr wants to merge 7 commits intoturt2live:mainfrom
AndrewFerr wants to merge 7 commits intoturt2live:mainfrom
Conversation
Contributor
Author
|
I intend to add test coverage for this to prevent further regressions (whether self-inflicted or induced by dependency changes). |
Contributor
Author
|
On closer examination, the regression wasn't caused by #287, but by a change in the rust-sdk crypto crate which isn't yet in a release of the Node bindings (change = matrix-org/matrix-rust-sdk@98882b9, merging PR = matrix-org/matrix-rust-sdk#2142). With that said, this PR will be needed only after a new release of the rust-sdk Node bindings is cut. |
on account of it being removed from the crypto-sdk
OlmMachine.receiveSyncChanges returns an array of [device messages, room key changes], so emit "to_device.decrypted" with that instead of the entire array. Fixes regression introduced by turt2live#287.
Also condense the validity checks on the returned value
AndrewFerr
force-pushed
the
af/to-device-msgs-fix
branch
from
58c71bc to
d87f7d8
Compare
3 tasks
Contributor
Author
|
Note that this applies on top of #330 due to requiring an update of the rust-sdk bindings, which necessitates handling the omission of the Sled crypto store. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OlmMachine.receiveSyncChanges returns an array of [device messages, room key changes], so emit "to_device.decrypted" with that instead of the entire array.
Fixes regression introduced by #287.
Signed-off-by: Andrew Ferrazzutti andrewf@element.io
Checklist