Add check of inconsistent test namespaces.#29
Merged
Conversation
aaronweeden
requested review from
aestoltm,
connersaeli,
eiffel777,
jpwhite4 and
ryanrath
6 tasks
eiffel777
approved these changes
Dec 13, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In conjunction with ubccr/xdmod#1797, this PR moves the automated check of inconsistent test namespaces from ubccr/xdmod#1795 out of the
xdmodCircleCI config and into thexdmod-qastyle tests for PHP files that have been added or changed. This way, the code does not have to be duplicated in the CircleCI config of each submodule of XDMoD, and it does not have to run for every file, only those that changed.