Skip to content

Remove test namespace linting.#1797

Merged
aaronweeden merged 1 commit into
ubccr:xdmod11.0from
aaronweeden:remove-test-namespace-linting
Dec 13, 2023
Merged

Remove test namespace linting.#1797
aaronweeden merged 1 commit into
ubccr:xdmod11.0from
aaronweeden:remove-test-namespace-linting

Conversation

@aaronweeden
Copy link
Copy Markdown
Contributor

Description

In conjunction with ubccr/xdmod-qa#29, this PR moves the automated check of inconsistent test namespaces from #1795 out of the xdmod CircleCI config and into the xdmod-qa style tests for PHP files that have been added or changed. This way, the code does not have to be duplicated in the CircleCI config of each submodule of XDMoD, and it does not have to run for every file, only those that changed.

Tests performed

In a Docker container running tools-ext-01.ccr.xdmod.org/xdmod-10.5.0-x86_64:rockylinux8.5-0.3:

git clone https://github.com/ubccr/xdmod /xdmod
git clone https://github.com/aaronweeden/xdmod-qa -b lint-test-namespaces /xdmod-qa
cd /xdmod-qa
composer install
cd /xdmod

Change namespaces in the tests directories and confirm this outputs them and fails the style tests:

/xdmod-qa/scripts/build.sh --remote remotes/origin/xdmod11.0 -s

Checklist:

  • The pull request description is suitable for a Changelog entry
  • The milestone is set correctly on the pull request
  • The appropriate labels have been added to the pull request

@aaronweeden aaronweeden merged commit 979ebca into ubccr:xdmod11.0 Dec 13, 2023
@aaronweeden aaronweeden deleted the remove-test-namespace-linting branch December 13, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qa / testing Updates/additions to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants