Faaction: HIPA

[AnAngrySalad1]

When merged this pull request will:

• Adds the HIPA faction (Horizon Islands Peoples Army)

[tbeswick96]

Code review

Found 9 issues across the HIPA faction addon.

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[tbeswick96]

units[] has multiple issues:

Name mismatches -- these don't match their actual class definitions:

• QGVAR(Autorifleman) (line 11) -- actual class is GVAR(sf_autorifleman)
• QGVAR(Operator) (line 25) -- actual class is GVAR(sf_operator)
• QGVAR(Grenadier) (line 26) -- actual class is GVAR(sf_grenadier)
• QGVAR(HMG_01) (line 42) -- actual class is GVAR(auto_hmg)

Completely undefined -- no class definition exists anywhere in this addon:

• QGVAR(Armour_Crewman) (line 16)
• QGVAR(Jet_Pilot) (line 20)
• QGVAR(Paratrooper) (line 24)

Missing from units[] -- these are defined with scope = 2 but not registered:

• GVAR(sf_operator), GVAR(sf_sfc), GVAR(sf_grenadier), GVAR(sf_autorifleman), GVAR(sf_LAT)
• GVAR(Officer_HQ)
• GVAR(LSV_01_unarmed_SF), GVAR(LSV_01_armed_SF)
• GVAR(auto_hmg), GVAR(Mini_Radar_Dish)

[tbeswick96]

weapons[] lists class names that don't exist:

No GVAR wrapper defined -- these are stock CUP/vanilla classes used bare in unit definitions, not custom weapons:

• QGVAR(CUP_lmg_MG3) (line 63)
• QGVAR(CUP_arifle_G36C) (line 66)
• QGVAR(CUP_glaunch_M32) (line 68)

Wrong variant name:

• QGVAR(CUP_arifle_G36C_VFG_CUP_optic_HensoldtZO_low_RDS_CUP_acc_ANPEQ_15_Black) (line 67) -- only the _suppressed variant is defined
• QGVAR(CUP_arifle_MG36_CUP_optic_HensoldtZO_low_RDS_CUP_acc_ANPEQ_15_Black) (line 69) -- only the _suppressed variant is defined
• QGVAR(CUP_arifle_G36C_VFG_ACE_optic_MRCO_2D_acc_flashlight_suppressed) (line 70) -- only the non-suppressed variant is defined

[tbeswick96]

GVAR(T55) in CfgArmored.hpp inherits from uksf_eug_T55, but uksf_eug is not in requiredAddons[]. This dependency is needed to guarantee correct load order.

[tbeswick96]

These #include directives should be in alphabetical order. Current order:

CfgFactionClasses -> CfgGroups -> CfgVehicles -> CfgWeapons -> CfgEditorSubcategories

Alphabetical:

CfgEditorSubcategories -> CfgFactionClasses -> CfgGroups -> CfgVehicles -> CfgWeapons

[tbeswick96]

Soldier_Base overrides weapons[] from O_Soldier_base_F but does not include "Put" and "Throw". This strips the ability to throw grenades and place inventory items from every unit that inherits without overriding weapons[] (Rifleman, Officer, Signaller, etc.).

Should be:

weapons[] = {QGVAR(CUP_arifle_G36C_VFG_ACE_optic_MRCO_2D_acc_flashlight), "Put", "Throw"};
respawnWeapons[] = {QGVAR(CUP_arifle_G36C_VFG_ACE_optic_MRCO_2D_acc_flashlight), "Put", "Throw"};

Other units that override weapons[] are also missing Put/Throw: Squad_Leader, Sharpshooter, sf_autorifleman, Officer_HQ, Sniper, Crewman.

[tbeswick96]

Unquoted class name -- CUP_lmg_MG3 needs to be a quoted string "CUP_lmg_MG3". Bare identifiers in arrays will fail to resolve correctly.

Also missing "Put" and "Throw".

[tbeswick96]

Unquoted class name -- CUP_glaunch_M32 needs to be a quoted string "CUP_glaunch_M32". Also missing "Put" and "Throw".

[tbeswick96]

Unquoted class name -- CUP_arifle_G36C needs to be a quoted string "CUP_arifle_G36C". Also missing "Put" and "Throw".

[tbeswick96]

Two issues here:

1. UK English: Armor should be Armour (class name and displayName). CLAUDE.md requires UK English spelling.

2. Placeholder TODO comments: // Add armor groups and // Add other categories indicate incomplete work. Either add the group definitions or remove the empty class and comment.