fix(build_pipeline): FIN-100g-4 deploy-parity must not rescue a malformed test run (H-1)#383
Closed
urlmonitor wants to merge 1 commit into
Closed
fix(build_pipeline): FIN-100g-4 deploy-parity must not rescue a malformed test run (H-1)#383urlmonitor wants to merge 1 commit into
urlmonitor wants to merge 1 commit into
Conversation
…rmed test run (H-1) Post-merge code review found a HIGH defect in the FIN-100g-4 deploy-parity self-check: a malformed Step-3 test-runner reply is treated conservatively as testPassed=false with an EMPTY postMergeFailures, but the block ran on any !testPassed and, filtering an already-empty set, flipped testPassed->true — skipping triage/HALT and merging on a malformed test run. Fix: gate the block AND the flip on postMergeFailures.length > 0 (H-1), so an empty/ambiguous result can never be rescued to passed. Add an M-2 contradiction guard: exclude a failure only if the agent reports it build-state AND NOT in still_failing (previously the still_failing field was ignored) — bounding trust in the classification; triage stays the sole authority that can HALT. Backfills the load-bearing behavioral tests the audit flagged (execute real JS via the E2 harness): H-1 empty-set skips deploy-parity; FIN-100g-4-i a genuine failure survives exclusion and reaches triage; M-2 contradiction not excluded; plus a FIN-100g-3-i source-order guard (found:false return precedes the main-branch abort). 38 passed; ruff clean. Residual (noted follow-up): a well-formed-but-wrong agent reply is still trusted (M-1) — full mitigation would forward to triage as sole authority.
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-merge code review + logic check of the finalize-hardening work found a HIGH defect in the FIN-100g-4 deploy-parity self-check (introduced in #381).
H-1: a malformed Step-3 test-runner reply is treated conservatively as
testPassed=falsewith an emptypostMergeFailures. The deploy-parity block ran on any!testPassed; filtering an already-empty set left it empty, sotestPassedflipped to true → triage/HALT skipped → merge on a malformed test run.Fix
postMergeFailures.length > 0— an empty/ambiguous result can never be rescued to passed (H-1).still_failing(thestill_failingfield was previously ignored) — bounds trust in the classification; triage stays the sole authority that can HALT.Test plan (behavioral — execute real JS via the E2 harness)
build_state_only_failuresandstill_failingis not excluded.found:falsereturn precedes the main-branch abort.Residual (noted follow-up)
A well-formed-but-wrong agent reply is still trusted (M-1); full mitigation would forward the claim to triage as the sole clearing authority — a deeper FIN-100c change, out of scope for this fix.
🤖 Generated with Claude Code