fix(build_pipeline): FIN-100g-4 deploy-parity must not rescue a malformed test run (H-1)#385
Merged
Merged
Conversation
…rmed test run (H-1) Post-merge code review found a HIGH defect in the FIN-100g-4 deploy-parity self-check: a malformed Step-3 test-runner reply is treated conservatively as testPassed=false with an EMPTY postMergeFailures, but the block ran on any !testPassed and, filtering an already-empty set, flipped testPassed->true — skipping triage/HALT and merging on a malformed test run. Fix: gate the block AND the flip on postMergeFailures.length > 0 (H-1), so an empty/ambiguous result can never be rescued to passed. Add an M-2 contradiction guard: exclude a failure only if the agent reports it build-state AND NOT in still_failing (previously the still_failing field was ignored) — bounding trust in the classification; triage stays the sole authority that can HALT. Backfills the load-bearing behavioral tests the audit flagged (execute real JS via the E2 harness): H-1 empty-set skips deploy-parity; FIN-100g-4-i a genuine failure survives exclusion and reaches triage; M-2 contradiction not excluded; plus a FIN-100g-3-i source-order guard (found:false return precedes the main-branch abort). 38 passed; ruff clean. Residual (noted follow-up): a well-formed-but-wrong agent reply is still trusted (M-1) — full mitigation would forward to triage as sole authority.
urlmonitor
added a commit
that referenced
this pull request
Jul 23, 2026
…ting, deploy-parity (FIN-100g/FIN-100c) (#386) Adds one changelog entry (type: fix, component build_pipeline) recording the finalize-feature hardening effort merged across PRs #379-#382 and #385: pre-flight accepts string-or-object targets, actionable unresolvable-target errors, and a deploy-parity self-check (with the H-1 empty-set guard) that suppresses false test_regression halts. Co-authored-by: Test User <test@example.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased successor to #383 (its branch could not be force-pushed onto the new main that carries the BO-2500b proof-of-done workflow from #378).
Summary
FIN-100g-4's post-merge deploy-parity rescue in
finalize-feature.jscould fliptestPassedto true on an empty exclusion set (H-1). This gates the rescue onpostMergeFailures.length > 0, adds a still-failing contradiction guard so a target that is both build-state-only and still-failing is never excluded, and adds behavioral tests that execute the JS under the E2 harness.Test plan
Supersedes #383.
🤖 Generated with Claude Code