Closed
Conversation
- Custom ProseMirror plugin renders a virtual caret (hides native) - Smooth 60ms CSS transition between positions while typing - Blink pauses while typing, resumes 0.5s after last keystroke - Line and underline styles switchable via Appearance > Cursor menu - Style persisted to localStorage and restored on startup Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
) * Initial plan * Fix module-level state and silent failure in caret plugin Co-authored-by: usamaasfar <42825498+usamaasfar@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: usamaasfar <42825498+usamaasfar@users.noreply.github.com>
Codex
AI
changed the title
Owner
|
@codex[agent] can you fix the issue? |
Contributor
Author
Fixed the Biome config and lint blockers; checks now pass. Commit 09f0a01. |
Codex
AI
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| className="cmdk-overlay" | ||
| onClick={onClose} | ||
| onKeyDown={(e) => { | ||
| if (e.key === "Escape" || e.key === "Enter" || e.key === " ") { |
Contributor
There was a problem hiding this comment.
Enter and Space handlers prevent command selection. Users navigating with arrows can't select items with Enter because overlay closes first. Only Escape should close the overlay on keydown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR addresses PR comments and linting issues from the custom caret implementation. The changes include fixing the Biome configuration typo (
assist→assists), resolving variable shadowing inlistIsTight, organizing imports per Biome rules, and adding keyboard accessibility to the command bar overlay.Key changes:
indexvariableOne issue found: the CommandBar keyboard handler intercepts Enter/Space keys that should be handled by the command palette items for selection.
Confidence Score: 4/5
Important Files Changed
Last reviewed commit: 2eb67be