Addressing PR comments

apps/desktop/src-tauri/tauri.conf.json

@@ -26,23 +26,15 @@
     "active": true,
     "targets": "all",
     "createUpdaterArtifacts": true,
-    "icon": [
-      "icons/32x32.png",
-      "icons/128x128.png",
-      "icons/128x128@2x.png",
-      "icons/icon.icns",
-      "icons/icon.ico"
-    ],
+    "icon": ["icons/32x32.png", "icons/128x128.png", "icons/128x128@2x.png", "icons/icon.icns", "icons/icon.ico"],
     "macOS": {
       "signingIdentity": null
     }
   },
   "plugins": {
     "updater": {
       "pubkey": "dW50cnVzdGVkIGNvbW1lbnQ6IG1pbmlzaWduIHB1YmxpYyBrZXk6IDg4RTRDMDREMjdGNjYxODcKUldTSFlmWW5UY0RraUlaTjZwYmV6MjRnWGs3QWs3U3o2YmpGbEJ5akV0MER2b2I1M3V4LzNoem4K",
-      "endpoints": [
-        "https://github.com/usamaasfar/superscript/releases/latest/download/latest.json"
-      ]
+      "endpoints": ["https://github.com/usamaasfar/superscript/releases/latest/download/latest.json"]
     }
   },
   "version": "../../../package.json"

apps/desktop/src/App.tsx

@@ -5,8 +5,8 @@ import { useCallback, useEffect, useRef, useState } from "react";
 import { CommandBar } from "~/command/CommandBar";
 import { Editor } from "~/editor/Editor";
 import { useAppearance } from "~/hooks/useAppearance";
-import { useAutoUpdate } from "~/hooks/useAutoUpdate";
 import { useAutoSave } from "~/hooks/useAutoSave";
+import { useAutoUpdate } from "~/hooks/useAutoUpdate";
 import { useFileSystem } from "~/hooks/useFileSystem";
 import { useRename } from "~/hooks/useRename";
 import { getFileStem } from "~/utils/file";
@@ -44,21 +44,19 @@ function App() {
     setActivePath,
   });
 
-  const { isRenaming, renameValue, setRenameValue, renameInputRef, startRename, submitRename, resetRename } = useRename(
-    {
-      activePath,
-      files,
-      flushSave,
-      loadDir,
-      setActivePath,
-      setActiveContent,
-      setEditorKey: (updater) => {
-        const next = updater(editorKeyRef.current);
-        editorKeyRef.current = next;
-        setEditorKey(next);
-      },
+  const { isRenaming, renameValue, setRenameValue, renameInputRef, startRename, submitRename, resetRename } = useRename({
+    activePath,
+    files,
+    flushSave,
+    loadDir,
+    setActivePath,
+    setActiveContent,
+    setEditorKey: (updater) => {
+      const next = updater(editorKeyRef.current);
+      editorKeyRef.current = next;
+      setEditorKey(next);
     },
-  );
+  });
 
   const openFile = useCallback(
     async (path: string) => {

apps/desktop/src/command/CommandBar.tsx

@@ -8,7 +8,17 @@ interface Props {
 
 export function CommandBar({ files, onSelect, onClose }: Props) {
   return (
-    <div className="cmdk-overlay" onClick={onClose}>
+    <div
+      className="cmdk-overlay"
+      onClick={onClose}
+      onKeyDown={(e) => {
+        if (e.key === "Escape" || e.key === "Enter" || e.key === " ") {
+          e.preventDefault();
+          onClose();
+        }
+      }}
+      tabIndex={-1}
+    >
       <Command className="cmdk-palette" onClick={(e) => e.stopPropagation()}>
         <Command.Input autoFocus placeholder="Find file…" />
         <Command.List>

apps/desktop/src/editor/Editor.tsx

@@ -8,6 +8,7 @@ import { EditorView } from "prosemirror-view";
 import { useEffect, useRef } from "react";
 import { caretPlugin } from "./plugins/caret";
 import { parseMarkdown, schema, serializeMarkdown } from "./markdown";
+import { caretPlugin } from "./plugins/caret";
 
 function buildInputRules() {
   return inputRules({

apps/desktop/src/editor/markdown.ts

@@ -1,6 +1,6 @@
 import MarkdownIt from "markdown-it";
 import type Token from "markdown-it/lib/token.mjs";
-import { defaultMarkdownSerializer, MarkdownParser, MarkdownSerializer } from "prosemirror-markdown";
+import { MarkdownParser, MarkdownSerializer, defaultMarkdownSerializer } from "prosemirror-markdown";
 import { Schema } from "prosemirror-model";
 
 // schema: CommonMark nodes + strikethrough mark
@@ -168,7 +168,8 @@ export const schema = new Schema({
 });
 
 function listIsTight(tokens: Token[], i: number) {
-  while (++i < tokens.length) if (tokens[i].type !== "list_item_open") return tokens[i].hidden;
+  let index = i;
+  while (++index < tokens.length) if (tokens[index].type !== "list_item_open") return tokens[index].hidden;
   return false;
 }
 

apps/desktop/src/editor/plugins/caret.ts

@@ -37,10 +37,7 @@ function updateCaret(view: EditorView, el: HTMLElement) {
   const lineHeight = cursorRect.bottom - cursorRect.top;
   el.setAttribute("data-style", caretStyle);
   el.style.left = `${cursorRect.left - containerRect.left}px`;
-  el.style.top =
-    caretStyle === "underline"
-      ? `${cursorRect.bottom - containerRect.top - 2}px`
-      : `${cursorRect.top - containerRect.top}px`;
+  el.style.top = caretStyle === "underline" ? `${cursorRect.bottom - containerRect.top - 2}px` : `${cursorRect.top - containerRect.top}px`;
   el.style.height = caretStyle === "underline" ? "2px" : `${lineHeight}px`;
 
   // restart blink so caret stays solid while typing

apps/desktop/src/hooks/useAutoUpdate.ts

@@ -6,7 +6,11 @@ export function useAutoUpdate(): void {
   useEffect(() => {
     check()
       .then((update) => {
-        if (update) update.downloadAndInstall().then(() => relaunch()).catch(console.error);
+        if (update)
+          update
+            .downloadAndInstall()
+            .then(() => relaunch())
+            .catch(console.error);
       })
       .catch(console.error);
   }, []);

apps/desktop/src/hooks/useFileSystem.ts

@@ -1,6 +1,6 @@
+import { homeDir } from "@tauri-apps/api/path";
 import { open } from "@tauri-apps/plugin-dialog";
 import { mkdir, readDir, stat } from "@tauri-apps/plugin-fs";
-import { homeDir } from "@tauri-apps/api/path";
 import { useCallback, useEffect, useState } from "react";
 
 interface UseFileSystemOptions {

apps/desktop/src/styles/editor.css

@@ -142,6 +142,11 @@
 }
 
 @keyframes pm-caret-blink {
-  0%, 100% { opacity: 1; }
-  50% { opacity: 0; }
+  0%,
+  100% {
+    opacity: 1;
+  }
+  50% {
+    opacity: 0;
+  }
 }

apps/desktop/src/styles/globals.css

@@ -84,9 +84,7 @@ body {
   border-radius: 0;
   background: transparent;
   color: var(--fg);
-  font-family:
-    -apple-system, BlinkMacSystemFont, "SF Pro Text", "Helvetica Neue",
-    sans-serif;
+  font-family: -apple-system, BlinkMacSystemFont, "SF Pro Text", "Helvetica Neue", sans-serif;
   font-size: 0.78rem;
   font-weight: 500;
   line-height: 1.1;

apps/desktop/tsconfig.json

@@ -20,8 +20,8 @@
     "strict": true,
     "noUnusedLocals": true,
     "noUnusedParameters": true,
-    "noFallthroughCasesInSwitch": true,
+    "noFallthroughCasesInSwitch": true
   },
   "include": ["src"],
-  "references": [{ "path": "./tsconfig.node.json" }],
+  "references": [{ "path": "./tsconfig.node.json" }]
 }

apps/desktop/vite.config.ts

@@ -1,7 +1,7 @@
+import { resolve } from "node:path";
 import tailwindcss from "@tailwindcss/vite";
-import { defineConfig } from "vite";
 import react from "@vitejs/plugin-react";
-import { resolve } from "path";
+import { defineConfig } from "vite";
 
 // @ts-expect-error process is a nodejs global
 const host = process.env.TAURI_DEV_HOST;

biome.json

@@ -24,12 +24,7 @@
       "quoteStyle": "double"
     }
   },
-  "assist": {
-    "enabled": true,
-    "actions": {
-      "source": {
-        "organizeImports": "on"
-      }
-    }
+  "assists": {
+    "enabled": true
   }
 }

package.json

@@ -19,7 +19,5 @@
     "node": ">=18"
   },
   "packageManager": "bun@1.3.9",
-  "workspaces": [
-    "apps/*"
-  ]
+  "workspaces": ["apps/*"]
 }