Add CI with linting, formatting and testing (including docs)#6
Conversation
|
I removed the macro expansions, as they would be too hard to maintain and they are an implementation detail. |
|
I added a drive-by fix for the lifetime test failure, let me know if it is appropriate. |
|
Hi, thanks for fixing the test, I think I rushed a bit the commit 😵💫 I'll have a better look at the example snippets and see if I can clarify EnumAccessor. Also I know some Rust docs have runnable snippets that hide the boilerplate ( ex : https://rust-lang.github.io/async-book/02_execution/03_wakeups.html#applied-build-a-timer ), but maybe it's not available to snippets added to a README.md |
I created a draft PR (#8) to differentiate accessors based on aliases also (I just modified the condition for emitting the duplicate accessor error to include the alias). This didn't break any existing tests, but I feel like there are some edge cases that could break it. I'll try to add more tests for such edge cases before merging this.
This is a rustdoc feature so I'm pretty sure that GitHub would render these lines with the |
you're right, the current state of README is some braindump to compensate ... that there is no other doc. Hopefully documentation and runnable examples can be directly be attached to I have to review my tests and make sure it cover wells the intended feature. 9 months ago already I hope I'll remember what I tried to do 😵💫 |
Add check, test, fmt and clippy.
|
Alright, now it looks and is professional. |
|
woa thanks I added a bit more coverage with some more (lame) smoke tests – at least there is a good branch coverage except for error cases. I'll merge this to see those shiny badges |


I had to rework the examples in the
README.mdin order to pass the doc tests. They are now completely functional and copy-pastable, except theEnumAccessoralias. Maybe my understanding of this feature is incomplete.