Make accessor alias differentiate accessors to the same attribute name#8
Draft
tlaferriere wants to merge 17 commits into
Draft
Make accessor alias differentiate accessors to the same attribute name#8tlaferriere wants to merge 17 commits into
tlaferriere wants to merge 17 commits into
Conversation
Add check, test, fmt and clippy.
# Conflicts: # README.md
tlaferriere
marked this pull request as draft
June 18, 2023 15:49
# Conflicts: # .github/workflows/rust.yml # README.md
Found a potential bug in the accessor method generation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7
By checking differences in both the ident and the alias, we can allow this usecase.
Note: this is based on the branch of #6 so should be merged after it.