-
Notifications
You must be signed in to change notification settings - Fork 0
App 15608 enable joint position pasting #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4dd5e86
feat: add pasting joint positions
mattmacf98 ce18c0f
Merge branch 'main' into APP-15608-enable-joint-position-pasting
mattmacf98 3317d24
add pasting for move to position
mattmacf98 4635800
remove error log
mattmacf98 a536db8
use IconButton
mattmacf98 cd2e08d
fix format es lint conflicting
mattmacf98 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@viamrobotics/test-widgets': minor | ||
| --- | ||
|
|
||
| feat: allow pasting for moveToPositions and moveToPose widgets" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| <script lang="ts"> | ||
| import { IconButton, Tooltip } from '@viamrobotics/prime-core' | ||
|
|
||
| interface Props { | ||
| onPaste: (data: string) => boolean | ||
| ariaLabel?: string | ||
| } | ||
|
|
||
| const { onPaste, ariaLabel = 'Paste from clipboard' }: Props = $props() | ||
|
|
||
| let isPasteSuccessful = $state<boolean | null>(null) | ||
|
|
||
| const handlePasteClick = async (event: Event) => { | ||
| event.stopPropagation() | ||
| event.preventDefault() | ||
| const data = await globalThis.navigator.clipboard.readText() | ||
| isPasteSuccessful = onPaste(data) | ||
| setTimeout(() => { | ||
| isPasteSuccessful = null | ||
| }, 750) | ||
| } | ||
|
|
||
| const iconName = $derived( | ||
| // eslint-disable-next-line unicorn/no-nested-ternary | ||
| isPasteSuccessful === null ? 'content-paste' : isPasteSuccessful ? 'check' : 'close' | ||
| ) | ||
| </script> | ||
|
|
||
| <Tooltip> | ||
| <IconButton | ||
| onclick={handlePasteClick} | ||
| aria-label={ariaLabel} | ||
| class="text-gray-6 hover:border-medium hover:bg-medium active:bg-gray-2 justify-items-end p-0.5" | ||
| icon={iconName} | ||
| label="Paste from clipboard" | ||
| /> | ||
| <span slot="description">{ariaLabel}</span> | ||
| </Tooltip> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated to PR but I thought these buttons should have a tool tip (especially bc there is now a copy and paste one)