Detect and define GRAPHICSMAGICK_VERSION_MASK on Windows#60
Open
cmb69 wants to merge 1 commit intovitoc:masterfrom
Open
Detect and define GRAPHICSMAGICK_VERSION_MASK on Windows#60cmb69 wants to merge 1 commit intovitoc:masterfrom
cmb69 wants to merge 1 commit intovitoc:masterfrom
Conversation
We basically use the same logic as on other platforms, but since there is likely no GraphicsMagick-config on Windows, we retrieve the information from magick/version.h. Note that this makes it possible to compile gmagick on Windows, what previously failed because `GMAGICK_LIB_MASK` was not defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We basically use the same logic as on other platforms, but since there is likely no GraphicsMagick-config on Windows, we retrieve the information from magick/version.h.
Note that this makes it possible to compile gmagick on Windows, what previously failed because
GMAGICK_LIB_MASKwas not defined.I compiled against PHP 8.2.21 and GraphicsMagick 1.3.23 (the old version should probably be updated); test suite: passed 177, failed 3. Not bad. :)