freebsd-amd64: reject exit-0 in the etext/end XFAIL signature check - #81
Merged
GGRei merged 1 commit intoJul 27, 2026
Conversation
Fixes the same class of gap as pullrequestreview-4783389496 on the sibling macos-amd64 workflow, vlang#74 (applied here proactively): is_known_etext_end only rejected signal-terminated exits (>128), never exit 0 - a changed tcc.exe reporting the expected etext/end diagnostic as noise while still succeeding overall would still be accepted as the known XFAIL.
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #75. That PR merged before a Codex finding on the sibling
macos-amd64 workflow (pullrequestreview-4783389496, #74) was ported over
here, so it never made it in.
is_known_etext_endonly rejected signal-terminated exits (>128), neverexit 0. A changed
tcc.exethat starts printing the same etext/enddiagnostic as noise while still exiting 0 overall would still be accepted
as the known XFAIL — the text alone isn't proof the compile actually
failed. Now rejects both signal-terminated exits and exit 0, matching the
same hardening already merged on macos-amd64.
Single-line logic change, no other behavior affected.