Skip to content

freebsd-amd64: reject exit-0 in the etext/end XFAIL signature check #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GGRei merged 1 commit into from
Jul 27, 2026
Merged

freebsd-amd64: reject exit-0 in the etext/end XFAIL signature check #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,14 @@ jobs:
# pullrequestreview-4781865117 on vlang/tccbin#75). A POSIX
# shell reports a signal-terminated process as exit code
# 128+signal; reject those instead of treating any nonzero
# exit as "the expected compile-error status".
if [ "$2" -gt 128 ]; then
# exit as "the expected compile-error status". Also reject
# exit 0: a changed tcc.exe could start printing this same
# diagnostic as noise while still reporting overall success
# - the text alone isn't proof the compile actually failed
# (Codex pullrequestreview-4783389496 on the sibling
# macos-amd64 workflow, vlang/tccbin#74, same class of gap
# here).
if [ "$2" -eq 0 ] || [ "$2" -gt 128 ]; then
return 1
fi
case "$1" in
Expand Down