feat: add beforeTagInsert hook#1054
Merged
alexander-akait merged 1 commit intowebpack:masterfrom Jan 31, 2024
Merged
Conversation
|
|
Member
|
@msidolphin Also can you rebase, sorry for delay |
Contributor
Author
The generated version of package-lock is too old, should I update it? |
Member
|
@msidolphin Just rebase |
Contributor
Author
Okay, I'm done. |
c4c6601 to
86cc2be
Compare
alexander-akait
approved these changes
Jan 31, 2024
Member
|
Thank you, I will do release after #1057 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1054 +/- ##
==========================================
- Coverage 90.40% 90.31% -0.09%
==========================================
Files 5 6 +1
Lines 875 888 +13
Branches 256 259 +3
==========================================
+ Hits 791 802 +11
- Misses 74 76 +2
Partials 10 10 ☔ View full report in Codecov by Sentry. |
Member
|
I will fix errors in other PR, need more work |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Breaking Changes
Additional Info
When I tried webpack-subresource-integrity to inject integrities, I found that I couldn't add integrities to the style files if I also used mini-css-extract-plugin. due to the lack of hooks in mini-css-extract-plugin. Due to the lack of hooks in mini-css-extract-plugin, it is not possible to add additional attributes to the link tag.
Related issue
#40
Usage