feat: expand ruff lint rules with tier 1+2 quality rulesets#22
Merged
Conversation
Add 12 new ruff rule sets for code quality, bug prevention, and modernization. Fix all auto-fixable violations and manually resolve remaining issues including dead code, ambiguous unicode, raw regex strings, loop-to-comprehension conversions, and control flow simplification. New rule sets: UP (pyupgrade), B (bugbear), SIM (simplify), C4 (comprehensions), RUF (ruff-specific), PIE (misc cleanup), RET (return simplification), PERF (performance), PT (pytest style), FURB (modernization), FLY (f-string conversion). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
weklund
added a commit
that referenced
this pull request
Apr 4, 2026
🤖 I have created a release *beep* *boop* --- ## [0.3.5](v0.3.4...v0.3.5) (2026-04-04) ### Features * expand ruff lint rules with tier 1+2 quality rulesets ([#22](#22)) ([75490f6](75490f6)) ### Refactors * **tests:** replace brittle mock-heavy tests with behavioral tests and shared factories ([#32](#32)) ([9af6078](9af6078)) - `FakeServiceLayer` replaces 10-deep `@patch` stacks in `TestRunUp` - Consolidate ~50 duplicate helpers into `tests/factories.py` - AAA comments (`# Arrange`, `# Act`, `# Assert`) across 17 test files - `make lint` now includes pyright for shift-left type checking - Net: -577 lines, 1,481 tests pass, 73% reduction in `@patch` usage --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Wes Eklund <s.wes35@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
models.py)All 1480 unit tests pass.
make lint,make test, andmake test-catalogall green. Pre-existing failures in integration/smoke tests are unchanged (see #20, #21).Test plan
make lint— all checks passedmake test— 1480 passed, 89% coveragemake test-catalog— 121 passedmake test-integration— same pre-existing failure as main (Integration test flaky: port still bound after shutdown in test_full_lifecycle #20)make test-smoke— same pre-existing failure as main (Smoke test ReadTimeout: health check passes but inference times out for qwen3.5-0.8b #21)🤖 Generated with Claude Code