Skip to content

Remove Pin lock from the app#8236

Merged
daniloercoli merged 4 commits intodevelopfrom
feature/remove_passcode_lock
Aug 28, 2018
Merged

Remove Pin lock from the app#8236
daniloercoli merged 4 commits intodevelopfrom
feature/remove_passcode_lock

Conversation

@planarvoid
Copy link
Contributor

Fixes #29

  • in order to fix a security issue in PasscodeLock library we have decided to remove the library completely from the app. The Pin lock feature has very low usage and presents a security issue. The project is no longer maintained.

To test:

  • go to App settings
  • Pin lock category is gone

@daniloercoli daniloercoli self-assigned this Aug 27, 2018
@malinajirka
Copy link
Contributor

Thanks Vojta!

I missed it's already assigned, sorry. I've reviewed it and tested it. LGTM.

@loremattei loremattei modified the milestones: 10.8, 10.9 Aug 28, 2018
@loremattei
Copy link
Contributor

Hey! I moved the milestone to 10.9 since 10.8 has been cut. Please, feel free to move it back to 10.8 if it has to land there: just target it to the release branch and ping me to update the build!

@daniloercoli daniloercoli merged commit 53268c3 into develop Aug 28, 2018
@daniloercoli
Copy link
Contributor

Looks good! :shipit:

@daniloercoli daniloercoli deleted the feature/remove_passcode_lock branch August 28, 2018 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants