fix: persist follow-up user messages after app restart#44
Merged
Conversation
Follow-up prompts from send_message were kept in memory only; restarting Orbit dropped them from the chat. Mirror create_session by writing the user JSONL line to session_outputs before spawn. Co-authored-by: José Fernando <xinnaider@users.noreply.github.com>
Co-authored-by: José Fernando <xinnaider@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Follow-up messages sent after the initial session prompt were shown in the live chat but not written to SQLite. After restarting Orbit or reloading a session from the database, those user prompts disappeared from the feed — silent data loss for multi-turn conversations.
Root cause
create_sessionwas updated to persist the first user message viainsert_output, butSessionManager::send_messageonly updated in-memoryjournal_statesand emittedsession:outputwithout storing the JSONL line.load_session_journal/restore_from_dbonly replay rows fromsession_outputs.Fix
send_messageusing the same Claude-style user JSONL format as session creation.emit_spawn_startedalready skips duplicate user lines when the journal contains the same text, so no double-write on spawn.should_restore_follow_up_user_message_from_dbintegration test.Validation
cargo test --lib restore_follow_up(pass)