Make xsimd_scalar.hpp independent from xsimd::batch#1178
Merged
serge-sans-paille merged 2 commits intoOct 13, 2025
Conversation
Contributor
Author
|
@DiamonDinoia / @JohanMabille this patch changes the behavior when no arch is supported. Previous behavior was "lots of meaningless error". After the patch of this patchset, the error becomes a type error "xsimd::batch does not exist" and after the second patch of this patcheset, we have a proper static assert. |
JohanMabille
approved these changes
Oct 13, 2025
Contributor
|
Hi @serge-sans-paille I think this is a good idea. Do you think my workaround #1143 (comment) is going to break due to the static_assert? |
Contributor
Author
|
@DiamonDinoia given the include order and the change I've made, I don't think it will break: you'lle never end up with the fallback batch type |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This paves the way for cleaner error when trying to instantiate an xsimd::batch when to architecture is available.
Related to #1143