Skip to content

Make xsimd_scalar.hpp independent from xsimd::batch #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serge-sans-paille merged 2 commits into from
Oct 13, 2025
Merged

Make xsimd_scalar.hpp independent from xsimd::batch #1178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
101c534
Make xsimd_scalar.hpp independent from xsimd::batch
serge-sans-paille Oct 12, 2025
74d315e
Proper static_assert when trying to instantiate a batch while no arch…
serge-sans-paille Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 1 addition & 20 deletions include/xsimd/arch/xsimd_scalar.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,6 @@

namespace xsimd
{
template <class T, class A>
class batch;
template <class T, class A>
class batch_bool;

using std::abs;

using std::acos;
Expand Down Expand Up @@ -779,20 +774,6 @@ namespace xsimd

namespace detail
{
template <class T>
struct value_type_or_type_helper
{
using type = T;
};
template <class T, class A>
struct value_type_or_type_helper<batch<T, A>>
{
using type = T;
};

template <class T>
using value_type_or_type = typename value_type_or_type_helper<T>::type;

template <class T0, class T1>
XSIMD_INLINE typename std::enable_if<std::is_integral<T1>::value, T0>::type
ipow(const T0& x, const T1& n) noexcept
Expand All @@ -801,7 +782,7 @@ namespace xsimd
T0 a = x;
T1 b = n;
bool const recip = b < 0;
T0 r(static_cast<value_type_or_type<T0>>(1));
T0 r(static_cast<T0>(1));
while (1)
{
if (b & 1)
Expand Down
11 changes: 10 additions & 1 deletion include/xsimd/xsimd.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,16 @@
#include "memory/xsimd_aligned_allocator.hpp"

#if defined(XSIMD_NO_SUPPORTED_ARCHITECTURE)
// to type definition or anything appart from scalar definition and aligned allocator
// no type definition or anything apart from scalar definition and aligned allocator
namespace xsimd
{
template <class T, class A = void>
class batch
{
static constexpr bool supported_architecture = sizeof(A*) == 0; // type-dependant but always false
static_assert(supported_architecture, "No SIMD architecture detected, cannot instantiate a batch");
};
}
#else
#include "types/xsimd_batch.hpp"
#include "types/xsimd_batch_constant.hpp"
Expand Down