Merged
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sophiedeziel and the rest of your teammates on |
11 tasks
3071658 to
cdaebe1
Compare
871f16c to
4dae155
Compare
a75f06c to
678a96f
Compare
4dae155 to
e7c4d8b
Compare
256595a to
e32e879
Compare
e7c4d8b to
46e385b
Compare
Merged
46e385b to
57b62fe
Compare
d81f5ea to
8c2c327
Compare
57b62fe to
96dc517
Compare
96dc517 to
a6c0cd0
Compare
This was referenced Oct 16, 2024
|
Visit the preview URL for this PR (updated for commit 3b52aaf): https://gcode-preview--pr224-reintroduce-toleranc-1jcvwxaa.web.app (expires Fri, 15 Nov 2024 03:27:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 59bd114ae4847b32c2bba0b68620b9069a3e3531 |
This was referenced Oct 16, 2024
Merged
sophiedeziel
added a commit
that referenced
this pull request
Oct 19, 2024
* Bring back the tolerance logic * Simplify the options
sophiedeziel
added a commit
that referenced
this pull request
Oct 24, 2024
* Bring back the tolerance logic * Simplify the options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Part of #221
Bringing back layer tolerance for z-axis movements and added configuration options for minimum layer threshold.
minLayerThresholdoption to the lib optionsJob0.05(same as before)