Replicate MaxSavedMoves to clients#16
Open
Calypto wants to merge 3 commits intozenakuten:mainfrom
Open
Conversation
The client log would show this despite the server's configured value being higher: BS_xPlayer: Exceeded max saved moves (250), consider increasing
zenakuten
reviewed
May 2, 2026
| } | ||
| } | ||
|
|
||
| // Configured MaxSavedMoves doesn't get replicated to clients without this -Calypto |
Owner
There was a problem hiding this comment.
This will update the value, but the fact it is not updated is some other fundamental issue that needs fixed.
All of other server variables are replicated, why this one not working? That's why I haven't merged this yet. Maybe we can just bump the default up until this is resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client log would show this despite the server's configured value being higher:
BS_xPlayer: Exceeded max saved moves (250), consider increasing