Skip to content

Replicate MaxSavedMoves to clients #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Calypto wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Replicate MaxSavedMoves to clients #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ace8a8
Fix MaxSavedMoves replication
Calypto Apr 10, 2026
25e9627
Merge branch 'zenakuten:main' into main
Calypto Apr 30, 2026
e068edb
Add bAllowTerrainDodge setting
Calypto Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Classes/BS_xPlayer.uc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4003,6 +4003,18 @@ event ClientSetViewTarget(Actor a)
}
}

// Configured MaxSavedMoves doesn't get replicated to clients without this -Calypto
Copy link
Copy Markdown
Owner

@zenakuten zenakuten May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will update the value, but the fact it is not updated is some other fundamental issue that needs fixed.

All of other server variables are replicated, why this one not working? That's why I haven't merged this yet. Maybe we can just bump the default up until this is resolved.

// BS_xPlayer: Exceeded max saved moves (250), consider increasing
simulated event PostNetReceive()
{
Super.PostNetReceive();

if (RepInfo != None && MaxSavedMoves != RepInfo.MaxSavedMoves)
{
SetMaxSavedMoves();
}
}

// From ModernPlayer by kokuei
// See PlayerController.uc on how this function works.
//
Expand Down
5 changes: 5 additions & 0 deletions Classes/MutUTComp.uc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@ var UTComp_Whitelist Whitelist;
var string OriginalStatsClass;

var config bool bDisableCameraShake;
var config bool bAllowTerrainDodge;

function PreBeginPlay()
{
Expand Down Expand Up @@ -933,6 +934,7 @@ function SpawnReplicationClass()
RepInfo.TeamRadarCullDistance = TeamRadarCullDistance;

RepInfo.bDisableCameraShake = bDisableCameraShake;
RepInfo.bAllowTerrainDodge = bAllowTerrainDodge;

for(i=0; i<VotingGametype.Length && i<ArrayCount(RepInfo.VotingNames); i++)
RepInfo.VotingNames[i]=VotingGametype[i].GameTypeName;
Expand Down Expand Up @@ -1684,6 +1686,7 @@ static function FillPlayInfo (PlayInfo PlayInfo)
PlayInfo.AddSetting("UTComp Settings", "SuicideInterval", "Minimum time between two suicides", security, weight, "Text", "0;0:1800",, False, False);
PlayInfo.AddSetting("UTComp Settings", "bDisableCameraShake", "Disable Camera Shake", security, weight, "Check");
PlayInfo.AddSetting("UTComp Settings", "bShowTeamScoresInServerBrowser", "Show team scores in server browser", security, weight, "Check");
PlayInfo.AddSetting("UTComp Movement", "bAllowTerrainDodge", "Allow dodging off terrain", security, weight, "Check");

weight++;
PlayInfo.AddSetting("UTComp Settings", "bShowSpawnsDuringWarmup", "Show Spawns during Warmup", security, weight,"Check");
Expand Down Expand Up @@ -1784,6 +1787,7 @@ static event string GetDescriptionText(string PropName)
case "bAllowTeamRadarMap": return "Allow players to use minimap team radar";
case "bDisableCameraShake": return "Disable camera shake effects";
case "bShowTeamScoresInServerBrowser": return "Check this to show team scores in the server browser";
case "bAllowTerrainDodge": return "Allow players to dodge off terrain.";

case "NewNetUpdateFrequency": return "NewNet Update Frequency (200)";
case "PingTweenTime": return "NewNet Ping Tween Time (3.0)";
Expand Down Expand Up @@ -2243,6 +2247,7 @@ defaultproperties
bAllowTeamRadarMap=false

bDisableCameraShake=false
bAllowTerrainDodge=false

bUseUTCompStats=true

Expand Down
4 changes: 3 additions & 1 deletion Classes/UTComp_ServerReplicationInfo.uc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ var bool bAllowTeamRadarMap;
var float TeamRadarCullDistance;

var bool bDisableCameraShake;
var bool bAllowTerrainDodge;

replication
{
Expand All @@ -102,7 +103,7 @@ replication
bAllowColorWeapons, bDamageIndicator, MaxSavedMoves, bEnableEmoticons, bKeepMomentumOnLanding, NetMoveDelta,
MaxResponseTime, bMoveErrorAccumFix, MoveErrorAccumFixValue, bLimitTaunts, TauntCount,
bAllowTeamRadar, bAllowTeamRadarMap, TeamRadarCullDistance,
bDisableCameraShake;
bDisableCameraShake, bAllowTerrainDodge;
}

defaultproperties
Expand Down Expand Up @@ -162,5 +163,6 @@ defaultproperties
TeamRadarCullDistance=10000.0

bDisableCameraShake=false
bAllowTerrainDodge=false
}

56 changes: 56 additions & 0 deletions Classes/UTComp_xPawn.uc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1412,6 +1412,62 @@ simulated function byte GetDefaultBrightColorMode()
return 6; // Always Brighter Blue
}

// Terrain dodging
function bool Dodge(eDoubleClickDir DoubleClickMove)
{
local vector X, Y, Z, Dir, Cross, TraceDir;
local vector TraceStart, TraceEnd, HitLocation, HitNormal;
local Actor HitActor;
local EPhysics SavedPhysics;
local bool bDidDodge;

if (RepInfo == None)
{
foreach DynamicActors(class'UTComp_ServerReplicationInfo', RepInfo)
break;
}

// Apply custom terrain logic when falling (sliding off steep slopes)
if (RepInfo != None && RepInfo.bAllowTerrainDodge && Physics == PHYS_Falling)
{
GetAxes(Rotation, X, Y, Z);

// Determine the dodge direction and cast the trace in the opposite direction
if (DoubleClickMove == DCLICK_Forward) { Dir = X; Cross = Y; TraceDir = -X; }
else if (DoubleClickMove == DCLICK_Back) { Dir = -X; Cross = Y; TraceDir = X; }
else if (DoubleClickMove == DCLICK_Left) { Dir = -Y; Cross = X; TraceDir = Y; }
else if (DoubleClickMove == DCLICK_Right) { Dir = Y; Cross = X; TraceDir = -Y; }

if (AIController(Controller) != None)
Cross = vect(0,0,0);

// Trace horizontally from the feet
TraceStart = Location - vect(0,0,1) * (CollisionHeight - 4.0);
TraceEnd = TraceStart + TraceDir * (CollisionRadius + 32.0);

// false = ignore actors, only trace world geometry (Terrain)
HitActor = Trace(HitLocation, HitNormal, TraceEnd, TraceStart, false);

// If we hit terrain, verify the angle opposes the dodge direction.
// (Dir Dot HitNormal > 0 ensures we are dodging away from the slope's face)
if (HitActor != None && HitActor.IsA('TerrainInfo') && (Dir Dot HitNormal) > 0)
{
SavedPhysics = Physics;
SetPhysics(PHYS_Falling);

bDidDodge = PerformDodge(DoubleClickMove, Dir, Cross);

// Restore physics state if the dodge failed or didn't lift us
if (!bDidDodge || Physics == PHYS_Walking)
SetPhysics(SavedPhysics);

return bDidDodge;
}
}

return Super.Dodge(DoubleClickMove);
}

defaultproperties
{
bAlwaysRelevant=True
Expand Down