feat(011): delete custom execution plumbing + integration tests (WP03+WP04)#33
Open
feat(011): delete custom execution plumbing + integration tests (WP03+WP04)#33
Conversation
This was referenced Mar 19, 2026
…ines/types.ts - Add ExecutionContext, PipelineStepHandler, StepHandlerRegistry to pipelines/types.ts - Delete src/pipelines/engine/, event-bus/, triggers/, init.ts - Delete src/benchmarks/step-latency.ts (benchmarked the deleted StepRunner) - Delete tests for all deleted modules (engine, triggers, event-bus, integration) - Fix all 17 import sites: redirect engine/step-runner.js -> pipelines/types.js - Replace EventBus in pipeline-executor.ts and executor.ts with inngest.send() - Replace initializePipelineModule in src/index.ts with direct StepRegistry/DecisionRecorder init - Remove eventBus from PipelineExecutorContext interface and all callers - Mock inngest client in tools.test.ts to fix pipeline_trigger test - tsc: 0 errors, vitest: 261/261 passing Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- corpus-update-pipeline: happy path, stub path, step output chaining, unique executionIds - content-audit-pipeline: approval/rejection/timeout paths, 72h timeout assertion, concurrency config - regulatory-change-monitor-pipeline: approval/rejection/timeout paths, 48h timeout (not 72h), source_query config - concurrency: all event-triggered pipelines use event.data.tenantId key; schedule-tick uses static CEL string literal 280 tests passing, tsc 0 errors. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
6aa0289 to
dd66174
Compare
Add gitignore exceptions and WP01-WP04 task stub files for kitty-specs/011-inngest-migration so the governance REF-001 check passes. Follows the same pattern as specs 005, 006, 007, 008, 009. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Entire-Checkpoint: fd7d2e1083a4
Member
Review note:
|
4 tasks
The manual trigger route sent inngest.send but no function was registered to handle it. Adds handler with per-tenant concurrency, two-step execution (source-query, content-generation), and stub fallback. Addresses grndlvl review comment on PR #33. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Entire-Checkpoint: a3fe5c9f5e37
Contributor
Author
|
Fixed in 69eb3b5 — added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29
Summary
This PR completes Feature 011 (Inngest Migration) — WP03 and WP04. WP01 (ported pipelines) and WP02 (replaced EventBus dispatch) are already on main.
WP03 — Delete custom execution plumbing (~5,013 LOC removed)
WP04 — Integration tests (19 tests across 4 suites)
No live Inngest server required — tests invoke the function internal fn handler with mocked step objects.
Acceptance gate (T018)
Reviewer checklist
Generated with Claude Code