Enhance run_comebin.sh and gen_cov_file.sh#34
Open
tnmquann wants to merge 1 commit intoziyewang:masterfrom
Open
Enhance run_comebin.sh and gen_cov_file.sh#34tnmquann wants to merge 1 commit intoziyewang:masterfrom
tnmquann wants to merge 1 commit intoziyewang:masterfrom
Conversation
…and improve BAM file handling
|
@tnmquann any chance these updates relax the dependency constraints? |
Author
Yes, the updates partly relax the constraints by allowing more flexible input handling (e.g., compressed files and regex-based file targeting), but they don’t modify COMEBin core dependencies. I'm currently still using the two modified bash scripts mentioned above, and the results remain consistent - no impact on output or performance observed so far. |
|
When I get some time, I'll try to fork yours so I can decrease the dependency restrictions. @ziyewang are you still actively developing this software? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @ziyewang,
I've made some modifications to the bash scripts
run_comebin.shandgen_cov_file.shfor better handling compressed files. I also add some improvements to make input and output handling more flexible, allowing the use of compressed files, regex expressions, and direct file references.Feel free to review and update them as needed. I have tested the revised scripts, and they run stably on my cluster.