Flywheel auto tuning#93
Open
Aztechs157-Git wants to merge 3 commits into
Open
Conversation
21 tasks
skrunked
reviewed
May 20, 2026
Contributor
skrunked
left a comment
skrunked
left a comment
There was a problem hiding this comment.
A couple minor cleanup changes, but otherwise good.
| private final FlyWheel flywheel; | ||
| private final SmartMotorController motor; | ||
| // motor object for sysID voltage control | ||
| private final TalonFX masterTalonFX; |
Contributor
There was a problem hiding this comment.
reference the original motor directly instead of using 'master', as 'master' is just a reference to the original motor.
|
|
||
| @Override | ||
| public void setVoltage(double volts) { | ||
| masterTalonFX.setControl(voltageRequest.withOutput(volts)); |
Contributor
There was a problem hiding this comment.
update to use original talonFX
| autoChooser.addOption( | ||
| "Drive SysId (Dynamic Reverse)", | ||
| drive.sysIdDynamic(SysIdRoutine.Direction.kReverse)); | ||
| autoChooser.addOption( |
Contributor
There was a problem hiding this comment.
add some sort of catch to not show these autos when connected to FMS
Contributor
There was a problem hiding this comment.
remove the SunstoneV2 mention as it is irrelevant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ranier put description here at some point.