ci: register pr-size as a caller fleet on the shared bump-callers.sh#35
Conversation
…callers dispatcher One dispatcher now serves every registered reusable workflow, each with its own caller-list Actions variable (cursor-review.yml keeps CURSOR_REVIEW_CALLERS unchanged; pr-size.yml registers against PR_SIZE_CALLERS for when it lands). Push events resolve which registered workflows actually changed via the compare API (falling back to a sweep of all registered workflows), and workflow_dispatch gains a workflows filter plus a read-only dry_run mode. Per-repo failures stay fault-isolated per workflow, and one workflow's bad caller variable cannot abort another's fan-out. Replaces bump-cursor-review-callers.yml.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 44 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
…r-size main landed #38 (generalize caller SHA-bump to the agents-md-integrity fleet) while this branch was open, extracting the bump logic into one shared script (.github/bump-callers/bump-callers.sh) driven by thin per-fleet entrypoint workflows instead of this PR's single-dispatcher-with-registry design. Rather than reintroduce a second, forked implementation of the same bump logic (exactly what #38's own "one implementation, not a fork" design note warns against, now also codified in this repo's AGENTS.md), this PR's remaining unique goal — registering pr-size as a caller fleet — is delivered the same way: a new bump-pr-size-callers.yml thin entrypoint over the existing shared script, mirroring bump-agents-md-callers.yml (ALLOW_EMPTY=true, since pr-size.yml hasn't landed yet). bump-callers.yml (this PR's original dispatcher) is dropped; the deleted bump-cursor-review-callers.yml keeps main's version (now a thin entrypoint over the shared script rather than the old inline implementation). Docs (bump-callers/README.md, bump-callers.sh header, AGENTS.md, test-bump-callers.yml paths) updated for the third fleet.
Restore the explicit `permissions: contents: read` this PR originally added (as a zizmor excessive-permissions fix on the old bump-cursor-review-callers.yml) across all three bump-*-callers.yml entrypoints — main's #38 shared-script version and the two pre-existing sibling entrypoints (bump-agents-md-callers.yml, bump-cursor-review-callers.yml) hadn't gained it, only the new bump-pr-size- callers.yml would have otherwise. None of the jobs write via GITHUB_TOKEN (all writes go through the generated app token), so read-only is correct and matches every other workflow file in this repo, which all declare explicit permissions.
|
Self-review: clean at HEAD c26fe33.
Ready for your merge. |
…ze-bump-callers # Conflicts: # .github/bump-callers/README.md # .github/workflows/bump-agents-md-callers.yml # .github/workflows/bump-cursor-review-callers.yml
Drop the stale bump-pr-size-callers.yml comment claiming pr-size.yml hasn't landed yet — it merged via #36 in the conflict-resolution merge.
|
🤖 The reviews loop filed Linear follow-up ticket(s) for review thread(s) deferred as out of scope for this PR:
|
ELI-5
This PR started as "turn the one cursor-review bump robot into a dispatcher that
also handles pr-size." While it was open,
mainlanded #38,which generalized the same bump robot a different way: one shared script
(
.github/bump-callers/bump-callers.sh) driven by a thin per-fleet entrypointworkflow, and used it to add a second fleet (agents-md-integrity). This PR now
reconciles with that: instead of a second, competing dispatcher implementation,
it registers pr-size as a third fleet on the now-shared script, the same way
agents-md-integrity was added.
What changed (revised after merging in #38)
bump-pr-size-callers.yml— a new thin entrypoint over.github/bump-callers/bump-callers.sh, mirroringbump-agents-md-callers.ymlexactly: triggers on a change to
pr-size.yml, uses thePR_SIZE_CALLERSvariable, and is seeded
ALLOW_EMPTY=true(the workflow hasn't landed yet, sothe fleet grows as callers get added — no different from how agents-md-integrity
onboarded).
.github/bump-callers/README.md,bump-callers.sh's header comment,test-bump-callers.yml's path filters, andAGENTS.mdupdated for the thirdfleet.
bump-callers.ymlsingle-dispatcher design (registry + compare-APIpush resolution +
workflows/dry_rundispatch inputs) is dropped — itwould have re-forked the bump logic ci(bump-callers): generalize caller SHA-bump to the agents-md-integrity fleet #38 just consolidated into one script,
which is exactly what ci(bump-callers): generalize caller SHA-bump to the agents-md-integrity fleet #38's own commit message (and this repo's
AGENTS.md,"One bumper, not several") says not to do. The per-workflow
paths:triggereach entrypoint already has does the same "only bump what actually changed"
job the compare-API resolution was for, natively.
Verification
shellcheck -x .github/bump-callers/bump-callers.sh .github/bump-callers/tests/test_bump_callers.sh— clean.bash .github/bump-callers/tests/test_bump_callers.sh— 25/25 passing, unchanged(the shared script itself wasn't touched, only a new caller of it was added).
python3 .github/agents-md-integrity/check_agents_md.py --root .— passes(pre-existing CODEOWNERS warning only).
bump-pr-size-callers.ymlagainstbump-agents-md-callers.ymlto confirmonly the intended per-fleet parameters differ (name, trigger path,
VAR_NAME,TAG,WORKFLOW_FILE).Judgment calls / notes for the reviewer
PR_SIZE_CALLERSvariable is seeded yet — same bootstrapping asAGENTS_MD_CALLERSwas:ALLOW_EMPTY=truemakes the entrypoint a clean no-opuntil the pr-size rollout starts adding callers.
pr-size.ymllands under a different filename than assumed here, the fix isthe
WORKFLOW_FILE/path-filter inbump-pr-size-callers.ymlalone.Follow-up fix (same tick)
Restored
permissions: contents: read(this PR's original zizmor-driven fix)across all three
bump-*-callers.ymlentrypoints — main's #38 merge andthis PR's new
bump-pr-size-callers.ymlhad all landed without an explicitpermissions:block. None of these jobs write viaGITHUB_TOKEN(writes gothrough the generated app token), so read-only is correct, and it now matches
every other workflow file in this repo (all of which declare explicit
permissions).