Add reading message times - #26
Draft
firesurfer wants to merge 2 commits into
Draft
Conversation
firesurfer
force-pushed
the
feature/add-reading-times
branch
from
July 9, 2026 10:22
ecb6271 to
a8d9a8d
Compare
firesurfer
requested review from
bbaier-duatic
and removed request for
svenkae1234
July 13, 2026 08:52
firesurfer
marked this pull request as draft
July 13, 2026 08:52
There was a problem hiding this comment.
Did you check the definition of the time_point for the used time base (chrono::microseconds vs chrono::nanoseconds)? In this code the time base could as well be microseconds since the update-rate is 1kHz and a jitter in the ns domain barely matters.
bbaier-duatic
approved these changes
Jul 16, 2026
bbaier-duatic
left a comment
bbaier-duatic
left a comment
There was a problem hiding this comment.
Make sure that nanoseconds is the correct time-base for this code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.