Conversation
…r, and support BYOC k8s clusters in daft-launcher Added docs for kuberay + daft installation, fixed minor linter issue
raunakab
reviewed
Jan 21, 2025
Contributor
raunakab
left a comment
There was a problem hiding this comment.
Looks good so far, but there are some configuration file changes that I think we should look over.
Also, I noticed that your editor removes the newlines (\n) from the end of the file. If you don't mind, could you try to keep them in? It usually is stylistic best practice to keep them in.
raunakab
reviewed
Jan 21, 2025
added 2 commits
January 21, 2025 17:36
15 tasks
raunakab
reviewed
Jan 22, 2025
raunakab
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support Daft on Kubernetes
This PR introduces support for Daft on existing Kubernetes clusters (BYOC - Bring Your Own Cluster) and improves documentation around cluster setup and SSH configuration.
Major Changes
1. Kubernetes Setup Documentation
2. CLI Enhancements & Command Support
Current command support matrix:
3. SSH Key Setup Documentation
Added instructions for SSH key setup in the README. Would appreciate review on:
daft upQuestions for Reviewers
Provider Naming:
awsvsk8smanagedvsbyocormanagedvsk8sCommand Structure:
daft up(fails for k8s with "not supported" message)daft aws up/daft k8s submitTesting Done
initandsubmit(will hold off on verifying the rest until after the high level approach detailed in this PR has been approved).Next Steps