Skip to content

fix(neoforge): guard null recipe source details - #6

Open
Exohayvan wants to merge 3 commits into
minecraft/neoforge-1.21.xfrom
minecraft-neoforge-1.21.x-fix-recipe_source_null_guard
Open

fix(neoforge): guard null recipe source details#6
Exohayvan wants to merge 3 commits into
minecraft/neoforge-1.21.xfrom
minecraft-neoforge-1.21.x-fix-recipe_source_null_guard

Conversation

@Exohayvan

Copy link
Copy Markdown
Owner

Summary

  • Initialize a missing or null recipe-source detail list with computeIfAbsent.
  • Keep recipe query processing alive when a present map key has a null list.
  • Add a regression test for the exact null-list state from the report.

Validation

  • bash ./gradlew test --tests net.exohayvan.dissolver_enhanced.data.EMCValuesTest.recipeSourceDetailReplacesNullList
  • bash ./gradlew test

Fixes #3

@Exohayvan Exohayvan linked an issue Jul 19, 2026 that may be closed by this pull request
@Exohayvan Exohayvan added the type:bug A defect or incorrect behavior label Jul 20, 2026
Repository owner deleted a comment from sonarqubecloud Bot Jul 20, 2026
@Exohayvan Exohayvan added P2 High: major functionality is broken or crashes with limited workaround area:recipes Recipe loading, querying, snapshots, or derived EMC loader:neoforge NeoForge-specific status:in-review A linked pull request is awaiting review or checks labels Jul 20, 2026
@Exohayvan Exohayvan added the status:in-progress Someone is actively implementing it label Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:recipes Recipe loading, querying, snapshots, or derived EMC loader:neoforge NeoForge-specific P2 High: major functionality is broken or crashes with limited workaround status:in-progress Someone is actively implementing it status:in-review A linked pull request is awaiting review or checks type:bug A defect or incorrect behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: NeoForge 1.21.1 NPE while recording recipe source details

1 participant