fix/refactor(provider): Initialize ctx + Plan canonicalization (#62, #63)

[intel352]

Summary

Closes two correctness gaps in DOProvider:

• DOProvider.Initialize ignores ctx parameter — godo client uses context.Background() #62 — Initialize now threads its caller-supplied ctx into oauth2.NewClient instead of constructing the godo client with context.Background(). Operators who inject a custom *http.Client via oauth2.HTTPClient (tests, custom transports, proxy configurations) now have that client honored end-to-end.
• DOProvider.Plan still non-canonical — refactor to platform.ComputePlan #63 — Plan is collapsed to the canonical 2-statement bridge over platform.ComputePlan. The hand-rolled body silently dropped (a) the ForceNew → replace upgrade and (b) DependsOn ordering, both of which the canonical helper enforces.

Reference: iac-deferred-cleanup plan rev10 §PR 6.

This PR is scoped to #62 + #63 only. The Enumerator interface implementation lives in the follow-up PR 6b (feat/do-enumerator-impl), which blocks on workflow PR 4 reaching main.

Changes

• internal/provider.go
  • Initialize accepts ctx (was _), forwards to oauth2.NewClient, rejects nil.
  • Plan becomes plan, err := platform.ComputePlan(ctx, p, desired, current); return &plan, err.
  • Removed the dead resourceOutputFromState helper.
• internal/provider_test.go
  • TestMain sets WFCTL_DIFFCACHE=disabled so the platform diff cache cannot poison test runs.
  • planDiffFakeDriver gains a sync.Mutex around its observable state (ComputePlan dispatches Diff in parallel via errgroup).
  • TestDOProvider_Initialize_NilCtxRejected and TestDOProvider_Initialize_ThreadsCtxToGodoClient pin DOProvider.Initialize ignores ctx parameter — godo client uses context.Background() #62.
  • TestDOProvider_Plan_KeepsDistinctCurrentStatePerConfigHashAction (legacy configHash-fallback) replaced with TestDOProvider_Plan_RejectsUnregisteredDriverType matching the new contract.

Test plan

• GOWORK=off go test -race -count=1 ./... (all green: internal + drivers + root)
• iac-codemod lint -dry-run internal/provider.go reports 0 findings (Plan canonical pattern recognized)
• CI on the PR: build, lint, conformance, release-dry-run all green

Out of scope

• DO Enumerator impl — separate PR 6b (feat/do-enumerator-impl); blocks on workflow PR 4 (Enumerator interface) reaching main.
• DO plugin v0.10.1 tag — cut after PR 6b merges (not after this PR), per plan rev10 §Coordination.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR closes two correctness gaps in DOProvider by (1) properly threading the caller’s context.Context into the DigitalOcean client initialization path, and (2) delegating planning to the workflow platform’s canonical platform.ComputePlan helper to restore replace/ordering semantics.

Changes:

• Update DOProvider.Initialize to require a non-nil ctx and pass it to oauth2.NewClient, ensuring ctx-injected oauth2.HTTPClient is honored end-to-end.
• Collapse DOProvider.Plan to the canonical 2-statement delegation to platform.ComputePlan, restoring ForceNew→replace promotion and dependency-correct action ordering.
• Adjust tests to disable the diffcache backend, add Initialize ctx coverage, and make the plan Diff fake concurrency-safe.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
internal/provider.go	Thread ctx into oauth2 client creation; delegate Plan to platform.ComputePlan and remove the now-unneeded local helper logic.
internal/provider_test.go	Disable diffcache for reproducible tests; add Initialize ctx tests; mutex-protect fake driver state; update Plan contract test expectations.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[intel352]

Fixed in 48b380e — capturing transport now returns a minimal valid JSON object body ({}) with a Content-Type header, and the comment is updated to match.